[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <b3e0a55f0680b590537133bfb02cd1bbfd61a56e.camel@sipsolutions.net>
Date: Wed, 12 Jun 2024 10:18:13 +0200
From: Johannes Berg <johannes@...solutions.net>
To: Zijun Hu <quic_zijuhu@...cinc.com>, davem@...emloft.net,
edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
emmanuel.grumbach@...el.com
Cc: linux-wireless@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v1 2/2] net: rfkill: Fix a logic error within
rfkill_set_hw_state_reason()
On Fri, 2024-06-07 at 22:40 +0800, Zijun Hu wrote:
> Kernel API rfkill_set_hw_state_reason() wrongly gets previous block state
> by using its parameter @reason as reason mask.
Using reason as a mask is perfectly valid.
And checking that the bit changed also seems valid.
We might want to not schedule the worker if it's not needed, but that's
a different issue, I don't see a real bug here?
johannes
Powered by blists - more mailing lists