[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c0ad3896334014ba2f12a7978b912e9c49b30d58.camel@sipsolutions.net>
Date: Wed, 12 Jun 2024 12:18:11 +0200
From: Johannes Berg <johannes@...solutions.net>
To: Zijun Hu <quic_zijuhu@...cinc.com>, davem@...emloft.net,
edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
emmanuel.grumbach@...el.com
Cc: linux-wireless@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v1 2/2] net: rfkill: Fix a logic error within
rfkill_set_hw_state_reason()
On Fri, 2024-06-07 at 22:40 +0800, Zijun Hu wrote:
> Kernel API rfkill_set_hw_state_reason() wrongly gets previous block state
> by using its parameter @reason as reason mask.
>
> Fixed by using @reason_mask as reason mask.
>
Actually, this *introduces* a bug. I'll leave it to you to figure out
what that is, I'm not convinced that you're actually doing *anything*
useful here.
johannes
Powered by blists - more mailing lists