netdev - Re: [PATCH net-next v5 07/12] net: dsa: lantiq_gswip: Use dsa_is_cpu_port() in gswip_port_change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 13 Jun 2024 14:34:38 +0200
From: Martin Schiller <ms@....tdt.de>
To: martin.blumenstingl@...glemail.com, hauke@...ke-m.de, andrew@...n.ch,
 f.fainelli@...il.com, olteanv@...il.com, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org
Cc: netdev@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v5 07/12] net: dsa: lantiq_gswip: Use
 dsa_is_cpu_port() in gswip_port_change_mtu()

On 2024-06-11 15:54, Martin Schiller wrote:
> From: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
> 
> Make the check for the CPU port in gswip_port_change_mtu() consistent
> with other areas of the driver by using dsa_is_cpu_port().
> 
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
> Reviewed-by: Vladimir Oltean <olteanv@...il.com>
> Acked-by: Hauke Mehrtens <hauke@...ke-m.de>
> ---
>  drivers/net/dsa/lantiq_gswip.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/dsa/lantiq_gswip.c 
> b/drivers/net/dsa/lantiq_gswip.c
> index 8ec329d0c136..58c069f964dd 100644
> --- a/drivers/net/dsa/lantiq_gswip.c
> +++ b/drivers/net/dsa/lantiq_gswip.c
> @@ -1464,12 +1464,11 @@ static int gswip_port_max_mtu(struct
> dsa_switch *ds, int port)
>  static int gswip_port_change_mtu(struct dsa_switch *ds, int port, int 
> new_mtu)
>  {
>  	struct gswip_priv *priv = ds->priv;
> -	int cpu_port = priv->hw_info->cpu_port;
> 
>  	/* CPU port always has maximum mtu of user ports, so use it to set
>  	 * switch frame size, including 8 byte special header.
>  	 */
> -	if (port == cpu_port) {
> +	if (dsa_is_cpu_port(ds, port)) {
>  		new_mtu += 8;
>  		gswip_switch_w(priv, VLAN_ETH_HLEN + new_mtu + ETH_FCS_LEN,
>  			       GSWIP_MAC_FLEN);

Signed-off-by: Martin Schiller <ms@....tdt.de>