[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <9d61982695053e49996f0c9c9ba708b7cfc13edb.camel@siemens.com>
Date: Thu, 13 Jun 2024 13:09:32 +0000
From: "Sverdlin, Alexander" <alexander.sverdlin@...mens.com>
To: "rogerq@...nel.org" <rogerq@...nel.org>, "s-vadapalli@...com"
<s-vadapalli@...com>
CC: "andrew@...n.ch" <andrew@...n.ch>, "yuehaibing@...wei.com"
<yuehaibing@...wei.com>, "davem@...emloft.net" <davem@...emloft.net>,
"p-varis@...com" <p-varis@...com>, "linux-kernel@...r.kernel.org"
<linux-kernel@...r.kernel.org>, "edumazet@...gle.com" <edumazet@...gle.com>,
"pabeni@...hat.com" <pabeni@...hat.com>, "jiri@...nulli.us"
<jiri@...nulli.us>, "srk@...com" <srk@...com>, "vladimir.oltean@....com"
<vladimir.oltean@....com>, "hkallweit1@...il.com" <hkallweit1@...il.com>,
"horms@...nel.org" <horms@...nel.org>, "dan.carpenter@...aro.org"
<dan.carpenter@...aro.org>, "kuba@...nel.org" <kuba@...nel.org>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH net-next] net: ethernet: ti: am65-cpsw: Add priv-flag for
Switch VLAN Aware mode
Hello Siddharth,
On Thu, 2024-02-29 at 16:37 +0530, Siddharth Vadapalli wrote:
> > A bit later the driver does this
> >
> > /* switch to vlan unaware mode */
> > cpsw_ale_control_set(common->ale, HOST_PORT_NUM, ALE_VLAN_AWARE, 1);
> > cpsw_ale_control_set(common->ale, HOST_PORT_NUM,
> > ALE_PORT_STATE, ALE_PORT_STATE_FORWARD);
> >
> > The comment says vlan unaware but code is setting ALE_VLAN_AWARE to 1.
> > Is the comment wrong?
I was asking myself the same question looking into the 3 drivers.
> ALE_VLAN_AWARE belongs to the "CPSW_ALE_CONTROL" register and is defined
> as:
> ALE_VLAN_AWARE determines how traffic is forwarded using VLAN rules.
> 0h = Simple switch rules, packets forwarded to all ports for unknown
> destinations.
> 1h = VLAN Aware rules, packets forwarded based on VLAN members.
So is our understanding correct? Shall I send a patch inverting the comment
in question?
--
Alexander Sverdlin
Siemens AG
www.siemens.com
Powered by blists - more mailing lists