netdev - Re: [PATCH net] gve: Clear napi->skb before dev_kfree_skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240613073928.5d588cf2@kernel.org>
Date: Thu, 13 Jun 2024 07:39:28 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Ziwei Xiao <ziweixiao@...gle.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
 pabeni@...hat.com, jeroendb@...gle.com, pkaligineedi@...gle.com,
 shailend@...gle.com, hramamurthy@...gle.com, willemb@...gle.com,
 rushilg@...gle.com, bcf@...gle.com, csully@...gle.com,
 linux-kernel@...r.kernel.org, stable@...nel.org, stable@...r.kernel.org
Subject: Re: [PATCH net] gve: Clear napi->skb before dev_kfree_skb_any()

On Wed, 12 Jun 2024 00:16:54 +0000 Ziwei Xiao wrote:
> +	if (rx->ctx.skb_head == napi->skb)
> +		napi->skb = NULL;

There doesn't seem to be much precedent for directly poking at this
field in drivers but I don't have any better ideas..