netdev - Re: [PATCH net-next v10 0/7] add ethernet driver for Tehuti Networks TN40xx chips

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 13 Jun 2024 09:14:38 -0700
From: Joe Damato <jdamato@...tly.com>
To: FUJITA Tomonori <fujita.tomonori@...il.com>
Cc: netdev@...r.kernel.org, andrew@...n.ch, horms@...nel.org,
	kuba@...nel.org, jiri@...nulli.us, pabeni@...hat.com,
	linux@...linux.org.uk, hfdevel@....net, naveenm@...vell.com,
	bhelgaas@...gle.com, linux-pci@...r.kernel.org
Subject: Re: [PATCH net-next v10 0/7] add ethernet driver for Tehuti Networks
 TN40xx chips

On Tue, Jun 11, 2024 at 01:52:10PM +0900, FUJITA Tomonori wrote:
> This patchset adds a new 10G ethernet driver for Tehuti Networks
> TN40xx chips. Note in mainline, there is a driver for Tehuti Networks
> (drivers/net/ethernet/tehuti/tehuti.[hc]), which supports TN30xx
> chips.
> 
> Multiple vendors (DLink, Asus, Edimax, QNAP, etc) developed adapters
> based on TN40xx chips. Tehuti Networks went out of business but the
> drivers are still distributed under GPL2 with some of the hardware
> (and also available on some sites). With some changes, I try to
> upstream this driver with a new PHY driver in Rust.
> 
> The major change is replacing the PHY abstraction layer in the original
> driver with phylink. TN40xx chips are used with various PHY hardware
> (AMCC QT2025, TI TLK10232, Aqrate AQR105, and Marvell MV88X3120,
> MV88X3310, and MV88E2010).
> 
> I've also been working on a new PHY driver for QT2025 in Rust [1]. For
> now, I enable only adapters using QT2025 PHY in the PCI ID table of
> this driver. I've tested this driver and the QT2025 PHY driver with
> Edimax EN-9320 10G adapter and 10G-SR SFP+. In mainline, there are PHY
> drivers for AQR105 and Marvell PHYs, which could work for some TN40xx
> adapters with this driver.
> 
> To make reviewing easier, this patchset has only basic functions. Once
> merged, I'll submit features like ethtool support.

Just a note for future feature support: it would be really great if
you also included the new netdev-genl APIs. For most drivers, it is
pretty easy to include and it allows userland to get more useful
information about the RX and TX queues.

Here's an example implementation for mlx4 to give you an idea of how
to use it:

  https://lore.kernel.org/netdev/20240513172909.473066-1-jdamato@fastly.com/

specifically:

  https://lore.kernel.org/netdev/20240513172909.473066-3-jdamato@fastly.com/

  and

  https://lore.kernel.org/netdev/20240513172909.473066-4-jdamato@fastly.com/
 
> v10:
> - Add Edimax Vendor ID to pci_ids.h (cleanup for wireless drivers later)
> - rename functions for mdio (use _c45 suffix for read/write and mdio_wait_nobusy)
> - clean up some tn40_rxdb_ functions
> - use unsinged int for static, nelem, and top in tn40_rxdb struct instead of int
> - return -ENODEV instead of -1 when PHY isn't found
> - remove the function to re-setting mdio speec to 1MHZ in tn40_priv_init()
> - cleanup tn40_mdio_set_speed()
> v9: https://lore.kernel.org/netdev/20240605232608.65471-1-fujita.tomonori@gmail.com/
> - move phylink_connect_phy() to simplify the ndo_open callback
> v8: https://lore.kernel.org/netdev/20240603064955.58327-1-fujita.tomonori@gmail.com/
> - remove phylink_mac_change() call
> - fix phylink_start() usage (call it after the driver is ready to operate).
> - simplify the way to get the private struct from phylink_config pointer
> - fix netif_stop_queue usage in mac_link_down callback
> - remove MLO_AN_PHY usage
> v7: https://lore.kernel.org/netdev/20240527203928.38206-7-fujita.tomonori@gmail.com/
> - use page pool API for rx allocation
> - fix NAPI API misuse
> - fix error checking of mdio write
> v6: https://lore.kernel.org/netdev/20240512085611.79747-2-fujita.tomonori@gmail.com/
> - use the firmware for TN30xx chips
> - move link up/down code to phylink's mac_link_up/mac_link_down callbacks
> - clean up mdio access code
> v5: https://lore.kernel.org/netdev/20240508113947.68530-1-fujita.tomonori@gmail.com/
> - remove dma_set_mask_and_coherent fallback
> - count tx_dropped
> - use ndo_get_stats64 instead of ndo_get_stats
> - remove unnecessary __packed attribute
> - fix NAPI API usage
> - rename tn40_recycle_skb to tn40_recycle_rx_buffer
> - avoid high order page allocation (the maximum is order-1 now)
> v4: https://lore.kernel.org/netdev/20240501230552.53185-1-fujita.tomonori@gmail.com/
> - fix warning on 32bit build
> - fix inline warnings
> - fix header file inclusion
> - fix TN40_NDEV_TXQ_LEN
> - remove 'select PHYLIB' in Kconfig
> - fix access to phydev
> - clean up readx_poll_timeout_atomic usage
> v3: https://lore.kernel.org/netdev/20240429043827.44407-1-fujita.tomonori@gmail.com/
> - remove driver version
> - use prefixes tn40_/TN40_ for all function, struct and define names
> v2: https://lore.kernel.org/netdev/20240425010354.32605-1-fujita.tomonori@gmail.com/
> - split mdio patch into mdio and phy support
> - add phylink support
> - clean up mdio read/write
> - use the standard bit operation macros
> - use upper_32/lower_32_bits macro
> - use tn40_ prefix instead of bdx_
> - fix Sparse errors
> - fix compiler warnings
> - fix style issues
> v1: https://lore.kernel.org/netdev/20240415104352.4685-1-fujita.tomonori@gmail.com/
> 
> [1] https://lore.kernel.org/netdev/20240415104701.4772-1-fujita.tomonori@gmail.com/
> 
> FUJITA Tomonori (7):
>   PCI: add Edimax Vendor ID to pci_ids.h
>   net: tn40xx: add pci driver for Tehuti Networks TN40xx chips
>   net: tn40xx: add register defines
>   net: tn40xx: add basic Tx handling
>   net: tn40xx: add basic Rx handling
>   net: tn40xx: add mdio bus support
>   net: tn40xx: add phylink support
> 
> MAINTAINERS                             |    8 +-
>  drivers/net/ethernet/tehuti/Kconfig     |   15 +
>  drivers/net/ethernet/tehuti/Makefile    |    3 +
>  drivers/net/ethernet/tehuti/tn40.c      | 1768 +++++++++++++++++++++++
>  drivers/net/ethernet/tehuti/tn40.h      |  231 +++
>  drivers/net/ethernet/tehuti/tn40_mdio.c |  142 ++
>  drivers/net/ethernet/tehuti/tn40_phy.c  |   76 +
>  drivers/net/ethernet/tehuti/tn40_regs.h |  245 ++++
>  include/linux/pci_ids.h                 |    2 +
>  9 files changed, 2489 insertions(+), 1 deletion(-)
>  create mode 100644 drivers/net/ethernet/tehuti/tn40.c
>  create mode 100644 drivers/net/ethernet/tehuti/tn40.h
>  create mode 100644 drivers/net/ethernet/tehuti/tn40_mdio.c
>  create mode 100644 drivers/net/ethernet/tehuti/tn40_phy.c
>  create mode 100644 drivers/net/ethernet/tehuti/tn40_regs.h
> 
> 
> base-commit: 2ebb87f45b3c6adc97b29291102ecb97274f913f
> -- 
> 2.34.1
>