netdev - Re: [PATCH net-next v2] net: dqs: introduce IFF_NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL+tcoAi7jOFJ+0hMNh1BnAg2A=tZ74FY-aYQ+-06WFVONtqQg@mail.gmail.com>
Date: Thu, 13 Jun 2024 10:23:57 +0800
From: Jason Xing <kerneljasonxing@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: edumazet@...gle.com, pabeni@...hat.com, davem@...emloft.net, 
	dsahern@...nel.org, mst@...hat.com, jasowang@...hat.com, 
	xuanzhuo@...ux.alibaba.com, eperezma@...hat.com, leitao@...ian.org, 
	netdev@...r.kernel.org, Jason Xing <kernelxing@...cent.com>
Subject: Re: [PATCH net-next v2] net: dqs: introduce IFF_NO_BQL private flag
 for non-BQL drivers

On Thu, Jun 13, 2024 at 5:40 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Tue, 11 Jun 2024 11:32:03 +0800 Jason Xing wrote:
> > +++ b/include/linux/netdevice.h
> > @@ -1649,6 +1649,9 @@ struct net_device_ops {
> >   * @IFF_SEE_ALL_HWTSTAMP_REQUESTS: device wants to see calls to
> >   *   ndo_hwtstamp_set() for all timestamp requests regardless of source,
> >   *   even if those aren't HWTSTAMP_SOURCE_NETDEV.
> > + * @IFF_NO_BQL: driver doesn't use BQL for flow control for now. It's used
> > + *   to check if we should create byte_queue_limits directory in dqs
> > + *   (see netdev_uses_bql())
>
> Sorry for nit but since it's netdevice.h.. can we rephrase the comment
> a bit? How about just:
>
> + * @IFF_NO_BQL: driver doesn't support BQL, don't create "byte_queue_limits"
> + *     directories in sysfs.

No problem. I will revise it as you said. Thanks.