netdev - Re: [PATCH v1] net: mvpp2: use slab_build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f0ec06fe746c612a5c7c72159e89e51ed0af1953.camel@alliedtelesis.co.nz>
Date: Thu, 13 Jun 2024 03:39:55 +0000
From: Aryan Srivastava <Aryan.Srivastava@...iedtelesis.co.nz>
To: "kees@...nel.org" <kees@...nel.org>
CC: "linux@...linux.org.uk" <linux@...linux.org.uk>, "davem@...emloft.net"
	<davem@...emloft.net>, "mw@...ihalf.com" <mw@...ihalf.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kuba@...nel.org" <kuba@...nel.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"pabeni@...hat.com" <pabeni@...hat.com>
Subject: Re: [PATCH v1] net: mvpp2: use slab_build_skb for oversized frames

On Wed, 2024-06-12 at 20:34 -0700, Kees Cook wrote:
> On Thu, Jun 13, 2024 at 03:13:34AM +0000, Aryan Srivastava wrote:
> > On Wed, 2024-06-12 at 20:05 -0700, Kees Cook wrote:
> > > On Thu, Jun 13, 2024 at 02:49:00PM +1200, Aryan Srivastava wrote:
> > > > Setting frag_size to 0 to indicate kmalloc has been deprecated,
> > > > use slab_build_skb directly.
> > > > 
> > > > Fixes: ce098da1497c ("skbuff: Introduce slab_build_skb()")
> > > > Signed-off-by: Aryan Srivastava
> > > > <aryan.srivastava@...iedtelesis.co.nz>
> > > > ---
> > > > Changes in v1:
> > > > - Added Fixes tag
> > > 
> > > This looks like similar updates like commit 99b415fe8986 ("tg3:
> > > Use
> > > slab_build_skb() when needed")
> > Yeah, I noticed that when I was looking for examples of other
> > "Fixes"
> > tags for the "skbuff: Introduce slab_build_skb()" commit. I suspect
> > there are many drivers that will need this "fix".
> 
> Yeah, at the time the API changes was made it was clear it wasn't
> easy
> to identify which needed it, so the WARN was added along with
> supporting
> the old style via internal fall-back.
> 
> -Kees
I love that about the kernel. Just nudges you in the right direction.

-Aryan
> 
> > > 
> > > Reviewed-by: Kees Cook <kees@...nel.org>
> > > 
> > 
>