netdev - Re: [PATCH net V4 2/3] net: lan743x: Support WOL at both the PHY and MAC appropriately

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240613071532.tx376cehgvqjgyqx@DEN-DL-M31836.microchip.com>
Date: Thu, 13 Jun 2024 09:15:32 +0200
From: Horatiu Vultur <horatiu.vultur@...rochip.com>
To: Raju Lakkaraju <Raju.Lakkaraju@...rochip.com>
CC: <netdev@...r.kernel.org>, <davem@...emloft.net>, <kuba@...nel.org>,
	<linux-kernel@...r.kernel.org>, <bryan.whitehead@...rochip.com>,
	<andrew@...n.ch>, <linux@...linux.org.uk>, <sbauer@...ckbox.su>,
	<hmehrtens@...linear.com>, <lxu@...linear.com>, <hkallweit1@...il.com>,
	<edumazet@...gle.com>, <pabeni@...hat.com>, <wojciech.drewek@...el.com>,
	<UNGLinuxDriver@...rochip.com>, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH net V4 2/3] net: lan743x: Support WOL at both the PHY and
 MAC appropriately

The 06/12/2024 22:55, Raju Lakkaraju wrote:

Hi Raju,

> Prevent options not supported by the PHY from being requested to it by the MAC
> Whenever a WOL option is supported by both, the PHY is given priority
> since that usually leads to better power savings.
> 
> Fixes: e9e13b6adc338 ("lan743x: fix for potential NULL pointer dereference with bare card")

I am not sure if you run checkpatch.pl, but this gives you a warning.
The sha has too many chars.

> Signed-off-by: Raju Lakkaraju <Raju.Lakkaraju@...rochip.com>
> Reviewed-by: Wojciech Drewek <wojciech.drewek@...el.com>
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202406052200.w3zuc32H-lkp@intel.com/

I still don't think you should add the 'Reported-by' and 'Closes' tags
here because you introduced the issue in first V3 of this patch series.
Because the intel robot says: "If you fix the issue in a separate
patch/commit (i.e. not just a new version of the same patch/commit),
kindly add following tags".

-- 
/Horatiu