netdev - Re: [PATCH net-next] fou: remove warn in gue_gro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iKwuRMWc8nosgHm3OuykayBMEZUCd1FJi+K+xn7xS2+rA@mail.gmail.com>
Date: Fri, 14 Jun 2024 14:31:08 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org, 
	pabeni@...hat.com, tom@...bertland.com, Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH net-next] fou: remove warn in gue_gro_receive on
 unsupported protocol

On Fri, Jun 14, 2024 at 2:25 PM Willem de Bruijn
<willemdebruijn.kernel@...il.com> wrote:
>
> From: Willem de Bruijn <willemb@...gle.com>
>
> Drop the WARN_ON_ONCE inn gue_gro_receive if the encapsulated type is
> not known or does not have a GRO handler.
>
> Such a packet is easily constructed. Syzbot generates them and sets
> off this warning.
>
> Remove the warning as it is expected and not actionable.
>
> The warning was previously reduced from WARN_ON to WARN_ON_ONCE in
> commit 270136613bf7 ("fou: Do WARN_ON_ONCE in gue_gro_receive for bad
> proto callbacks").
>
> Signed-off-by: Willem de Bruijn <willemb@...gle.com>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>