netdev - Re: [PATCH net v6 3/3] net: dsa: microchip: monitor potential faults in half-duplex mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <28b58ff0-599f-4157-9ccf-730c53217cf7@lunn.ch>
Date: Fri, 14 Jun 2024 15:37:12 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Enguerrand de Ribaucourt <enguerrand.de-ribaucourt@...oirfairelinux.com>
Cc: netdev@...r.kernel.org, hkallweit1@...il.com, linux@...linux.org.uk,
	woojung.huh@...rochip.com, UNGLinuxDriver@...rochip.com,
	horms@...nel.org, Tristram.Ha@...rochip.com,
	Arun.Ramadoss@...rochip.com
Subject: Re: [PATCH net v6 3/3] net: dsa: microchip: monitor potential faults
 in half-duplex mode

On Fri, Jun 14, 2024 at 09:46:42AM +0000, Enguerrand de Ribaucourt wrote:
> The errata DS80000754 recommends monitoring potential faults in
> half-duplex mode for the KSZ9477 family.
> 
> half-duplex is not very common so I just added a critical message
> when the fault conditions are detected. The switch can be expected
> to be unable to communicate anymore in these states and a software
> reset of the switch would be required which I did not implement.

If i'm reading this code correctly, every 30 seconds it will test to
see if the link is half duplex, and is so, log onetime this could lead
to problems. Also, every 30 seconds, if the statistics counts indicate
there has been a late collision, it will log a rate limited
message. Given the 30 second poll interval, rate limiting is probably
pointless, and every one will get logged. The last print, i have no
idea what resource you are talking about. Will it also likely print
once every 30 seconds?

Is the idea here, we want to notice when this is happening, and get an
idea if it is worth implementing the software reset? Do we want to add
a "Please report if you see this" to the commit message or the log
messages themselves?

	Andrew