netdev - Re: [PATCH net-next 0/2] vsock: avoid queuing on workqueue if possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <mfhi5is5533xyt4nlbpifrg6mpx3rye4n4vfg736irsae5tfx6@2aiorapp2uos>
Date: Fri, 14 Jun 2024 16:40:03 +0200
From: Stefano Garzarella <sgarzare@...hat.com>
To: Luigi Leonardi <luigi.leonardi@...look.com>
Cc: edumazet@...gle.com, virtualization@...ts.linux.dev, 
	netdev@...r.kernel.org, kuba@...nel.org, kvm@...r.kernel.org, stefanha@...hat.com, 
	pabeni@...hat.com, davem@...emloft.net
Subject: Re: [PATCH net-next 0/2] vsock: avoid queuing on workqueue if
 possible

On Fri, Jun 14, 2024 at 03:55:41PM GMT, Luigi Leonardi wrote:
>This patch series introduces an optimization for vsock/virtio to reduce latency:
>When the guest sends a packet to the host, and the workqueue is empty,
>if there is enough space, the packet is put directly in the virtqueue.

Thanks for working on this!!

I left few small comments.
I'm at DevConf this weekend, so I'll do a better review and some testing
next week.

Stefano

>
>The first one contains some code refactoring.
>More details and some performance tests in the second patch.
>
>Marco Pinna (2):
>  vsock/virtio: refactor virtio_transport_send_pkt_work
>  vsock/virtio: avoid enqueue packets when work queue is empty
>
> net/vmw_vsock/virtio_transport.c | 166 +++++++++++++++++++------------
> 1 file changed, 104 insertions(+), 62 deletions(-)
>
>-- 
>2.45.2
>