netdev - Re: [PATCH net V4 1/3] net: lan743x: disable WOL upon resume to restore full data path operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 14 Jun 2024 22:39:21 +0530
From: Raju Lakkaraju <Raju.Lakkaraju@...rochip.com>
To: Andrew Lunn <andrew@...n.ch>
CC: Raju Lakkaraju <Raju.Lakkaraju@...rochip.com>, "Russell King (Oracle)"
	<linux@...linux.org.uk>, <netdev@...r.kernel.org>, <davem@...emloft.net>,
	<kuba@...nel.org>, <linux-kernel@...r.kernel.org>,
	<bryan.whitehead@...rochip.com>, <sbauer@...ckbox.su>,
	<hmehrtens@...linear.com>, <lxu@...linear.com>, <hkallweit1@...il.com>,
	<edumazet@...gle.com>, <pabeni@...hat.com>, <wojciech.drewek@...el.com>,
	<UNGLinuxDriver@...rochip.com>
Subject: Re: [PATCH net V4 1/3] net: lan743x: disable WOL upon resume to
 restore full data path operation

Hi Andrew,

The 06/14/2024 16:17, Andrew Lunn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Fri, Jun 14, 2024 at 10:00:58AM +0530, Raju Lakkaraju wrote:
> > Hi Russell King,
> >
> > The 06/13/2024 08:44, Russell King (Oracle) wrote:
> > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> > >
> > > On Wed, Jun 12, 2024 at 10:55:37PM +0530, Raju Lakkaraju wrote:
> > > > @@ -3728,6 +3729,30 @@ static int lan743x_pm_resume(struct device *dev)
> > > >               return ret;
> > > >       }
> > > >
> > > > +     ret = lan743x_csr_read(adapter, MAC_WK_SRC);
> > > > +     netif_info(adapter, drv, adapter->netdev,
> > > > +                "Wakeup source : 0x%08X\n", ret);
> > >
> > > Does this need to be printed at info level, or is it a debug message?
> >
> > Print at info level helps the tester/sqa team to identify the root cause of
> > the wake and confirm the test cases.
> > In general, tester does not enable debug level messages for testing.
> >
> > Still, if we need to change from info to debug, i can change.
> > Please let me know.
> 
> We are not really writing a kernel for the tester/SQA team, but the
> end users. Do the end users find this log message useful? Can they
> decode some hex value into something meaningful?
> 

Yes. You are correct. We are writing code for end users.

But, our chip support different wake options which are testing by SQA team to
make sure all the options should work as per specifications and the output
respective input.
This message is not new and move from bottom.

As per Linux community review comment, I will move from "info" to "debug" in my
next patch series.

> I'm surprised the test case cares what caused the wakeup. So long as
> it does wake up, does it really matter what the source was?
> 
>         Andrew

-- 
Thanks,                                                                         
Raju