netdev - Re: [PATCH ipsec] xfrm: Fix unregister netdevice hang on hardware offload.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 14 Jun 2024 19:21:39 +0100
From: Simon Horman <horms@...nel.org>
To: Steffen Klassert <steffen.klassert@...unet.com>
Cc: Jianbo Liu <jianbol@...dia.com>, Eric Dumazet <edumazet@...gle.com>,
	netdev@...r.kernel.org
Subject: Re: [PATCH ipsec] xfrm: Fix unregister netdevice hang on hardware
 offload.

On Wed, Jun 12, 2024 at 11:11:41AM +0200, Steffen Klassert wrote:
> When offloading xfrm states to hardware, the offloading
> device is attached to the skbs secpath. If a skb is free
> is deffered, an unregister netdevice hangs because the

Hi Steffen,

Some minor nits from my side as it looks like there will be a v2 anyway.

deffered -> deferred

Flagged by checkpatch.pl --codespell

> netdevice is still refcounted.
> 
> Fix this by removing the netdevice from the xfrm states
> when the netdevice is unregisterd. To find all xfrm states

nit: unregistered

> that need to be cleared we add another list where skbs
> linked to that are unlinked from the lists (deleted)
> but not yet freed.
> 
> Fixes: d77e38e612a0 ("xfrm: Add an IPsec hardware offloading API")
> Tested-by: Jianbo Liu <jianbol@...dia.com>
> Signed-off-by: Steffen Klassert <steffen.klassert@...unet.com>

...