[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CANn89iLZFhzRVTf22dFMR5wChsUhGURy1AevfpwgzqF0LznyNQ@mail.gmail.com>
Date: Fri, 14 Jun 2024 08:38:48 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: "Nambiar, Amritha" <amritha.nambiar@...el.com>
Cc: Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net, netdev@...r.kernel.org,
pabeni@...hat.com, hawk@...nel.org, sridhar.samudrala@...el.com,
alardam@...il.com, lorenzo@...nel.org, memxor@...il.com
Subject: Re: [PATCH net] netdev-genl: fix error codes when outputting XDP features
On Fri, Jun 14, 2024 at 12:13 AM Nambiar, Amritha
<amritha.nambiar@...el.com> wrote:
>
> On 6/13/2024 2:30 PM, Jakub Kicinski wrote:
> > -EINVAL will interrupt the dump. The correct error to return
> > if we have more data to dump is -EMSGSIZE.
> >
> > Discovered by doing:
> >
> > for i in `seq 80`; do ip link add type veth; done
> > ./cli.py --dbg-small-recv 5300 --spec netdev.yaml --dump dev-get >> /dev/null
> > [...]
> > nl_len = 64 (48) nl_flags = 0x0 nl_type = 19
> > nl_len = 20 (4) nl_flags = 0x2 nl_type = 3
> > error: -22
> >
> > Fixes: d3d854fd6a1d ("netdev-genl: create a simple family for netdev stuff")
> > Signed-off-by: Jakub Kicinski <kuba@...nel.org>
>
> LGTM.
> Reviewed-by: Amritha Nambiar <amritha.nambiar@...el.com>
Reviewed-by: Eric Dumazet <edumazet@...gle.com>
Powered by blists - more mailing lists