netdev - Re: [PATCH net-next v12 03/13] netdev: support binding dma-buf to netdevice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e8763c5a-564f-4028-9a53-6952bb8d3567@web.de>
Date: Fri, 14 Jun 2024 10:36:11 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Kaiyuan Zhang <kaiyuanz@...gle.com>, Mina Almasry
 <almasrymina@...gle.com>, Willem de Bruijn <willemb@...gle.com>,
 netdev@...r.kernel.org, linux-alpha@...r.kernel.org,
 linux-mips@...r.kernel.org, linux-parisc@...r.kernel.org,
 sparclinux@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
 linux-trace-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
 bpf@...r.kernel.org, linux-kselftest@...r.kernel.org,
 linux-media@...r.kernel.org, dri-devel@...ts.freedesktop.org
Cc: LKML <linux-kernel@...r.kernel.org>, linux-doc@...r.kernel.org,
 Alexei Starovoitov <ast@...nel.org>, Andreas Larsson <andreas@...sler.com>,
 Andrii Nakryiko <andrii@...nel.org>, Arnd Bergmann <arnd@...db.de>,
 Bagas Sanjaya <bagasdotme@...il.com>,
 Christian König <christian.koenig@....com>,
 Christoph Hellwig <hch@...radead.org>, Daniel Borkmann
 <daniel@...earbox.net>, David Ahern <dsahern@...nel.org>,
 "David S. Miller" <davem@...emloft.net>, David Wei <dw@...idwei.uk>,
 Donald Hunter <donald.hunter@...il.com>, Eduard Zingerman
 <eddyz87@...il.com>, Eric Dumazet <edumazet@...gle.com>,
 Hao Luo <haoluo@...gle.com>, Harshitha Ramamurthy <hramamurthy@...gle.com>,
 Helge Deller <deller@....de>, Herbert Xu <herbert@...dor.apana.org.au>,
 Ilias Apalodimas <ilias.apalodimas@...aro.org>,
 Ivan Kokshaysky <ink@...assic.park.msu.ru>, Jakub Kicinski
 <kuba@...nel.org>,
 "James E. J. Bottomley" <James.Bottomley@...senPartnership.com>,
 Jason Gunthorpe <jgg@...pe.ca>, Jeroen de Borst <jeroendb@...gle.com>,
 Jesper Dangaard Brouer <hawk@...nel.org>, Jiri Olsa <jolsa@...nel.org>,
 John Fastabend <john.fastabend@...il.com>, Jonathan Corbet <corbet@....net>,
 KP Singh <kpsingh@...nel.org>, Martin KaFai Lau <martin.lau@...ux.dev>,
 Masami Hiramatsu <mhiramat@...nel.org>,
 Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
 Matt Turner <mattst88@...il.com>, Nikolay Aleksandrov <razor@...ckwall.org>,
 Paolo Abeni <pabeni@...hat.com>, Pavel Begunkov <asml.silence@...il.com>,
 Praveen Kaligineedi <pkaligineedi@...gle.com>,
 Richard Henderson <richard.henderson@...aro.org>,
 Sergey Shtylyov <s.shtylyov@....ru>, Shailend Chand <shailend@...gle.com>,
 Shakeel Butt <shakeel.butt@...ux.dev>, Shuah Khan <shuah@...nel.org>,
 Simon Horman <horms@...nel.org>, Song Liu <song@...nel.org>,
 Stanislav Fomichev <sdf@...gle.com>,
 Steffen Klassert <steffen.klassert@...unet.com>,
 Steven Rostedt <rostedt@...dmis.org>, Sumit Semwal
 <sumit.semwal@...aro.org>, Thomas Bogendörfer
 <tsbogend@...ha.franken.de>,
 Willem de Bruijn <willemdebruijn.kernel@...il.com>,
 Yonghong Song <yonghong.song@...ux.dev>,
 Yunsheng Lin <linyunsheng@...wei.com>
Subject: Re: [PATCH net-next v12 03/13] netdev: support binding dma-buf to
 netdevice

…
> +++ b/net/core/netdev-genl.c
…
>  int netdev_nl_bind_rx_doit(struct sk_buff *skb, struct genl_info *info)
>  {
…
> +	rtnl_lock();
> +
> +	netdev = __dev_get_by_index(genl_info_net(info), ifindex);
…
> +err_unlock:
> +	rtnl_unlock();
> +	return err;
>  }
…

Would you become interested to apply another lock guard?
https://elixir.bootlin.com/linux/v6.10-rc3/source/include/linux/cleanup.h#L124

Will scope-based resource management become more attractive
(also for the current source code adjustment)?

Regards,
Markus