netdev - Re: [PATCH net-next v10 4/7] net: tn40xx: add basic Tx handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sat, 15 Jun 2024 15:41:20 +0900 (JST)
From: FUJITA Tomonori <fujita.tomonori@...il.com>
To: kuba@...nel.org
Cc: fujita.tomonori@...il.com, netdev@...r.kernel.org, andrew@...n.ch,
 horms@...nel.org, jiri@...nulli.us, pabeni@...hat.com,
 linux@...linux.org.uk, hfdevel@....net, naveenm@...vell.com,
 jdamato@...tly.com
Subject: Re: [PATCH net-next v10 4/7] net: tn40xx: add basic Tx handling

On Fri, 14 Jun 2024 08:23:51 -0700
Jakub Kicinski <kuba@...nel.org> wrote:

>> Currently, net_device_stats struct is in tn40_priv struct. You meant
>> the driver shouldn't use net_device_stats struct?
> 
> Oh, I misread, I just saw netdev_stats_to_stats64( and didn't read
> further. Doesn't look like you're using any of the magic properties
> of struct net_device_stats, so yes, just replace it with struct
> rtnl_link_stats64 in the priv, and with minor adjustments that should be it.

I see. I'll replace the net_device_stats struct in the priv with
rtnl_link_stats64 struct. The minor adjustments include
u64_stats_sync, I suppose.