netdev - Re: [PATCH net] neighbour: add RTNL_FLAG_DUMP_SPLIT_NLM_DONE to RTM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANP3RGeBQCQhji0xWZXrzA7kbdgNWeD+GtNfsWFtZCvHAT0VVA@mail.gmail.com>
Date: Sat, 15 Jun 2024 13:29:02 +0200
From: Maciej Żenczykowski <maze@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Linux Network Development Mailing List <netdev@...r.kernel.org>, "David S . Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net] neighbour: add RTNL_FLAG_DUMP_SPLIT_NLM_DONE to RTM_GETNEIGH

On Sat, Jun 15, 2024 at 4:03 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Thu, 13 Jun 2024 07:12:15 -0700 Maciej Żenczykowski wrote:
> > Fixes: 3e41af90767d ("rtnetlink: use xarray iterator to implement rtnl_dump_ifinfo()")
> > Fixes: cdb2f80f1c10 ("inet: use xa_array iterator to implement inet_dump_ifaddr()")
>
> Did you just copy / paste those from the fix I pointed at?

I did, since this was caught in rc and never went into any 6.9 or earlier LTS,
I didn't put much thought into the fixes tag, thinking it didn't matter.

> I really think it should be:
>
> Fixes: 7e4975f7e7fb ("neighbour: fix neigh_dump_info() return value")

reverting the above does indeed fix things.  I'm resending.

I'll figure out what fixes the other one and resend too.

>
> Please double check that, correct, and resend. Same story for the other
> patch.

--
Maciej Żenczykowski, Kernel Networking Developer @ Google