netdev - Re: [PATCH net v2] ice: use proper macro for testing bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240615151641.GG8447@kernel.org>
Date: Sat, 15 Jun 2024 16:16:41 +0100
From: Simon Horman <horms@...nel.org>
To: Petr Oros <poros@...hat.com>
Cc: netdev@...r.kernel.org, ivecera@...hat.com,
	przemyslaw.kitszel@...el.com,
	Jesse Brandeburg <jesse.brandeburg@...el.com>,
	Tony Nguyen <anthony.l.nguyen@...el.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Marcin Szycik <marcin.szycik@...ux.intel.com>,
	Konrad Knitter <konrad.knitter@...el.com>,
	Marcin Domagala <marcinx.domagala@...el.com>,
	"moderated list:INTEL ETHERNET DRIVERS" <intel-wired-lan@...ts.osuosl.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net v2] ice: use proper macro for testing bit

On Fri, Jun 14, 2024 at 11:43:38AM +0200, Petr Oros wrote:
> Do not use _test_bit() macro for testing bit. The proper macro for this
> is one without underline.

Hi Petr,

it might be nice to include a brief explanation as to
why test_bit() is correct.

> 
> Fixes: 4da71a77fc3b ("ice: read internal temperature sensor")
> Signed-off-by: Petr Oros <poros@...hat.com>
> Acked-by: Ivan Vecera <ivecera@...hat.com>

...