netdev - Re: [PATCH resubmit 2] net: fec: Fix FEC_ECR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240614182731.3244deef@kernel.org>
Date: Fri, 14 Jun 2024 18:27:31 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Csókás Bence <csokas.bence@...lan.hu>
Cc: Frank Li <Frank.Li@...escale.com>, "David S. Miller"
 <davem@...emloft.net>, <imx@...ts.linux.dev>, <netdev@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, Richard Cochran <richardcochran@...il.com>,
 Wei Fang <wei.fang@....com>, Shenwei Wang <shenwei.wang@....com>, Clark
 Wang <xiaoning.wang@....com>, Eric Dumazet <edumazet@...gle.com>, Paolo
 Abeni <pabeni@...hat.com>
Subject: Re: [PATCH resubmit 2] net: fec: Fix FEC_ECR_EN1588 being cleared
 on link-down

On Fri, 14 Jun 2024 09:59:16 +0200 Csókás Bence wrote:
> It only writes 0 if WOL is disabled AND the device has the MULTI_QUEUES 
> quirk. Otherwise, we either write FEC_ECR_RESET, which resets the device 
> (and the HW changes ECNTRL to its reset value), OR we RMW set the WOL 
> sleep bits. And then, if some more quirks are set, we set ETHEREN.
> 
> So I think RMW is the safest route here, instead of trying to keep track 
> of all these different branches, re-read ECNTRL after reset etc.

Okay, just resend without the empty line between tags then.