netdev - Re: [PATCH net-next v10 4/7] net: tn40xx: add basic Tx handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8c67377e-888e-4c90-85a6-33983b323029@lunn.ch>
Date: Sun, 16 Jun 2024 16:59:22 +0200
From: Andrew Lunn <andrew@...n.ch>
To: FUJITA Tomonori <fujita.tomonori@...il.com>
Cc: hfdevel@....net, kuba@...nel.org, netdev@...r.kernel.org,
	horms@...nel.org, jiri@...nulli.us, pabeni@...hat.com,
	linux@...linux.org.uk, naveenm@...vell.com, jdamato@...tly.com
Subject: Re: [PATCH net-next v10 4/7] net: tn40xx: add basic Tx handling

On Sun, Jun 16, 2024 at 09:46:22PM +0900, FUJITA Tomonori wrote:
> On Sat, 15 Jun 2024 20:33:04 +0200
> Andrew Lunn <andrew@...n.ch> wrote:
> 
> > I did wounder if calculating the value as needed would be any
> > slower/faster than doing a table access. Doing arithmetic is very
> > cheap compared to a cache miss for a table lookup. Something which
> > could be bench marked and optimised later.
> 
> Indeed, that might be faster. I'll drop the table in the next
> version. I'll put that experiment on my to-do list.

I would generally recommend getting something merged, and then
optimise it. This could be in the noise, it makes no real difference.
By getting code merged, you make it easier for others to contribute to
this driver, and there does appear to be others who would like to work
on this code.

	Andrew