netdev - Re: [PATCH net-next 7/8] ionic: Use an u16 for rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ead82f17-b890-4834-9b18-8c548ed985d5@lunn.ch>
Date: Sun, 16 Jun 2024 03:28:54 +0200
From: Andrew Lunn <andrew@...n.ch>
To: David Laight <David.Laight@...lab.com>
Cc: 'Shannon Nelson' <shannon.nelson@....com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"kuba@...nel.org" <kuba@...nel.org>,
	"edumazet@...gle.com" <edumazet@...gle.com>,
	"pabeni@...hat.com" <pabeni@...hat.com>,
	"brett.creeley@....com" <brett.creeley@....com>,
	"drivers@...sando.io" <drivers@...sando.io>
Subject: Re: [PATCH net-next 7/8] ionic: Use an u16 for rx_copybreak

> > --- a/drivers/net/ethernet/pensando/ionic/ionic_lif.h
> > +++ b/drivers/net/ethernet/pensando/ionic/ionic_lif.h
> > @@ -206,7 +206,7 @@ struct ionic_lif {
> >  	unsigned int nxqs;
> >  	unsigned int ntxq_descs;
> >  	unsigned int nrxq_descs;
> > -	u32 rx_copybreak;
> > +	u16 rx_copybreak;
> >  	u64 rxq_features;
> >  	u16 rx_mode;
> 
> There seem to be 6 pad bytes here - why not just use them??

Or at least move rx_copybreak next to rx_mode so the compiler can pack
them together.

It would be good to include some output from pahole in the commit
message to show the goal of this patch has actually been reached.

     Andrew