netdev - Re: [PATCH] s390/lcs: add missing MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8357ad99-4627-4084-a000-9208f7c6c18a@linux.ibm.com>
Date: Mon, 17 Jun 2024 09:12:21 +0200
From: Alexandra Winter <wintera@...ux.ibm.com>
To: Jeff Johnson <quic_jjohnson@...cinc.com>,
        Thorsten Winkler <twinkler@...ux.ibm.com>,
        Heiko Carstens
 <hca@...ux.ibm.com>, Vasily Gorbik <gor@...ux.ibm.com>,
        Alexander Gordeev <agordeev@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ux.ibm.com>,
        Sven Schnelle <svens@...ux.ibm.com>
Cc: linux-s390@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] s390/lcs: add missing MODULE_DESCRIPTION() macro



On 16.06.24 06:23, Jeff Johnson wrote:
> With ARCH=s390, make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/s390/net/lcs.o
> 
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@...cinc.com>
> ---
>  drivers/s390/net/lcs.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/s390/net/lcs.c b/drivers/s390/net/lcs.c
> index 25d4e6376591..83807ce823e9 100644
> --- a/drivers/s390/net/lcs.c
> +++ b/drivers/s390/net/lcs.c
> @@ -2380,5 +2380,6 @@ module_init(lcs_init_module);
>  module_exit(lcs_cleanup_module);
>  
>  MODULE_AUTHOR("Frank Pavlic <fpavlic@...ibm.com>");
> +MODULE_DESCRIPTION("S/390 Lan Channel Station Network Driver");
>  MODULE_LICENSE("GPL");
>  
> 
> ---
> base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670
> change-id: 20240615-md-s390-drivers-s390-net-78a9068f1004
> 
> 


Thank you very much Jeff for noticing this and sending a patch.

I propose to describe the module as
"LAN channel station device driver"
as this is the term and spelling used in the documentation, e.g. here:
https://www.ibm.com/docs/en/linux-on-systems?topic=n-lcs-device-driver-4

Please send a v2