netdev - Re: [PATCH net-next v3 2/7] netlink: specs: Expand the PSE netlink command with C33 new features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m2frtc9ew7.fsf@gmail.com>
Date: Mon, 17 Jun 2024 09:01:28 +0100
From: Donald Hunter <donald.hunter@...il.com>
To: Kory Maincent <kory.maincent@...tlin.com>
Cc: "David S. Miller" <davem@...emloft.net>,  Eric Dumazet
 <edumazet@...gle.com>,  Jakub Kicinski <kuba@...nel.org>,  Paolo Abeni
 <pabeni@...hat.com>,  Oleksij Rempel <o.rempel@...gutronix.de>,  Thomas
 Petazzoni <thomas.petazzoni@...tlin.com>,  linux-kernel@...r.kernel.org,
  netdev@...r.kernel.org,  Dent Project <dentproject@...uxfoundation.org>,
  kernel@...gutronix.de
Subject: Re: [PATCH net-next v3 2/7] netlink: specs: Expand the PSE netlink
 command with C33 new features

Kory Maincent <kory.maincent@...tlin.com> writes:

> diff --git a/Documentation/netlink/specs/ethtool.yaml b/Documentation/netlink/specs/ethtool.yaml
> index 00dc61358be8..0ff27319856c 100644
> --- a/Documentation/netlink/specs/ethtool.yaml
> +++ b/Documentation/netlink/specs/ethtool.yaml
> @@ -20,6 +20,20 @@ definitions:
>      name: header-flags
>      type: flags
>      entries: [ compact-bitsets, omit-reply, stats ]
> +  -
> +    name: c33-pse-ext-state
> +    enum-name:
> +    type: enum
> +    entries: [ none,
> +               ethtool_c33_pse_ext_state_class_num_events,
> +               ethtool_c33_pse_ext_state_error_condition,
> +               ethtool_c33_pse_ext_state_mr_pse_enable,
> +               ethtool_c33_pse_ext_state_option_detect_ted,
> +               ethtool_c33_pse_ext_state_option_vport_lim,
> +               ethtool_c33_pse_ext_state_ovld_detected,
> +               ethtool_c33_pse_ext_state_pd_dll_power_type,
> +               ethtool_c33_pse_ext_state_power_not_available,
> +               ethtool_c33_pse_ext_state_short_detected ]

It looks like this should use name-prefix: ethtool-c33-pse-ext-state- so
that all the entries can be shortened.

The entries should be in hyphen-case, not snake_case.

The preferred format for a list that spills over many lines is to use
the yaml list format:

    entries:
      - none
      - class-num-events
      - error-condition
      - mr-pse-enable
      ...

Thanks!
--
Donald Hunter.