netdev - Re: [PATCH] wifi: mt76: un-embedd netdev from mt76

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <874j9rlxx5.fsf@kernel.org>
Date: Mon, 17 Jun 2024 12:29:42 +0300
From: Kalle Valo <kvalo@...nel.org>
To: Breno Leitao <leitao@...ian.org>
Cc: linux-wireless@...r.kernel.org,  Felix Fietkau <nbd@....name>,  Lorenzo
 Bianconi <lorenzo@...nel.org>,  Ryder Lee <ryder.lee@...iatek.com>,
  Shayne Chen <shayne.chen@...iatek.com>,  Sean Wang
 <sean.wang@...iatek.com>,  Matthias Brugger <matthias.bgg@...il.com>,
  AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
  netdev@...r.kernel.org,  horms@...nel.org,  kees@...nel.org,
  kuba@...nel.org,  Bo Jiao <Bo.Jiao@...iatek.com>,  Daniel Golle
 <daniel@...rotopia.org>,  Alexander Couzens <lynxis@...0.eu>,  Deren Wu
 <deren.wu@...iatek.com>,  Ming Yen Hsieh <mingyen.hsieh@...iatek.com>,
  Leon Yen <leon.yen@...iatek.com>,  Quan Zhou <quan.zhou@...iatek.com>,
  Ingo Rohloff <lundril@....de>,  Sujuan Chen <sujuan.chen@...iatek.com>,
  StanleyYP Wang <StanleyYP.Wang@...iatek.com>,  Benjamin Lin
 <benjamin-jw.lin@...iatek.com>,  Peter Chiu <chui-hao.chiu@...iatek.com>,
  "open list:ARM/Mediatek SoC support" <linux-kernel@...r.kernel.org>,
  "moderated list:ARM/Mediatek SoC support"
 <linux-arm-kernel@...ts.infradead.org>,  "moderated list:ARM/Mediatek SoC
 support" <linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCH] wifi: mt76: un-embedd netdev from mt76_dev

Breno Leitao <leitao@...ian.org> writes:

> Hello Kalle,
>
> On Mon, Jun 17, 2024 at 12:03:49PM +0300, Kalle Valo wrote:
>> Breno Leitao <leitao@...ian.org> writes:
>> 
>> > Embedding net_device into structures prohibits the usage of flexible
>> > arrays in the net_device structure. For more details, see the discussion
>> > at [1].
>> >
>> > Un-embed the net_devices from struct mt76_dev by converting them
>> > into pointers, and allocating them dynamically. Use the leverage
>> > alloc_netdev_dummy() to allocate the net_device object at
>> > mt76_dma_init().
>> >
>> > The free of the device occurs at mt76_dma_cleanup().
>> >
>> > Link: https://lore.kernel.org/all/20240229225910.79e224cf@kernel.org/ [1]
>> > Signed-off-by: Breno Leitao <leitao@...ian.org>
>> > ---
>> >
>> > PS: Due to the lack of hardware, this patch was not tested on a real
>> > hardware, unfortunately.
>> >
>> > PS2: this is the last driver that is still using embedded netdevices.
>> 
>> Is this patch a dependency to other patches? I'm asking because it will
>> be _slow_ to get this patch to net-next via wireless trees. If there's
>> urgency then it's much better to take it directly to net-next (of course
>> with acks from Felix and Lorenzo).
>
> Since this is the last patch for the whole flexible netdev work, I would
> prefer to have it through net-next then, so, we finish the whole work
> sooner rather than later.

Ok, even though I hate dealing with conflicts between trees I still
think it's better to get this directly to net-next. I hate "hurry up!"
emails even more ;)

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches