netdev - Re: [PATCH RFC net-next v2 3/8] net: stmmac: dwmac1000: convert sgmii/rgmii "pcs" to phylink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 18 Jun 2024 13:26:49 +0300
From: Serge Semin <fancer.lancer@...il.com>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: Andrew Halaney <ahalaney@...hat.com>, 
	Alexandre Torgue <alexandre.torgue@...s.st.com>, Jose Abreu <joabreu@...opsys.com>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Maxime Coquelin <mcoquelin.stm32@...il.com>, netdev@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com, 
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH RFC net-next v2 3/8] net: stmmac: dwmac1000: convert
 sgmii/rgmii "pcs" to phylink

On Fri, Jun 14, 2024 at 12:14:21AM +0300, Serge Semin wrote:
> On Wed, Jun 12, 2024 at 11:04:11PM +0100, Russell King (Oracle) wrote:
> > On Tue, Jun 11, 2024 at 03:25:14PM +0300, Serge Semin wrote:
> > > Hi Russell, Andrew
> > >
> > > Should we have a DW IP-core-specific getter like
> > > stmmac_ops::pcs_get_config_reg() which would return the
> > > tx_config_reg[15:0] field then we could have cleared the IRQ by just
> > > calling it, we could have had the fields generically
> > > parsed in the dwmac_pcs_isr() handler and in the
> > > phylink_pcs_ops::pcs_get_state().
> > 
> 
> [...]
> 
> > 
> > There's a good reason for this - dealing with latched-low link failed
> > indications, it's necessary that pcs_get_state() reports that the link
> > failed if _sometime_ between the last time it was called and the next
> > time the link has failed.
> > 
> > So, I'm afraid your idea of simplifying it doesn't sound to me like a
> > good idea.
> 
> No caching or latched link state indications. Both the GMAC_RGSMIIIS
> and GMAC_PHYIF_CONTROL_STATUS registers contain the actual link state
> retrieved the PHY. stmmac_pcs_get_config_reg() will just return the
> current link state.
> 
> Perhaps my suggestion might haven't been well described. Providing the
> patches with the respective changes shall better describe what was
> meant. So in a few days I'll submit an incremental patch(es) with the
> proposed modifications for your series

The incremental patchset is ready. I need to give it some more
tests, then rebase onto the kernel 6.10. It'll be done in one-two
days.

Thanks
-Serge(y)
.
> 
> -Serge(y)
> 
> > 
> > -- 
> > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> > FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!