netdev - Re: [PATCH net-next] net: core: Remove the dup_errno parameter in dev_prep_valid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 18 Jun 2024 16:05:57 +0200
From: Jiri Pirko <jiri@...nulli.us>
To: Yajun Deng <yajun.deng@...ux.dev>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: core: Remove the dup_errno parameter in
 dev_prep_valid_name()

Tue, Jun 18, 2024 at 03:17:43PM CEST, yajun.deng@...ux.dev wrote:
>netdev_name_in_use() return -EEXIST makes more sense if it's not NULL.
>But dev_alloc_name() should keep the -ENFILE errno.
>
>Remove the dup_errno parameter in dev_prep_valid_name() and add a
>conditional operator to dev_alloc_name(), replace -EEXIST with
>-ENFILE.
>
>Signed-off-by: Yajun Deng <yajun.deng@...ux.dev>

Why not.

Reviewed-by: Jiri Pirko <jiri@...dia.com>