netdev - Re: [PATCH v1 net-next] net: dsa: Allow only up to two HSR HW offloaded ports for KSZ9477

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6a011bd4-8494-4a6f-9ec4-723ab52c4fbf@lunn.ch>
Date: Tue, 18 Jun 2024 16:58:43 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Lukasz Majewski <lukma@...x.de>
Cc: Woojung.Huh@...rochip.com, dan.carpenter@...aro.org, olteanv@...il.com,
	kuba@...nel.org, netdev@...r.kernel.org, pabeni@...hat.com,
	edumazet@...gle.com, davem@...emloft.net, o.rempel@...gutronix.de,
	Tristram.Ha@...rochip.com, bigeasy@...utronix.de, horms@...nel.org,
	ricardo@...liere.net, casper.casan@...il.com,
	linux-kernel@...r.kernel.org, UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH v1 net-next] net: dsa: Allow only up to two HSR HW
 offloaded ports for KSZ9477

> For me the:
> 
> NL_SET_ERR_MSG_MOD(extack, "Cannot offload more than two ports (in
> use=0x%x)", dev->hsr_ports);
> 
> is fine - as it informs that no more HSR offloading is possible (and
> allows to SW based RedBox/HSR-SAN operation).

Does user space actually get to see it? I would expect the HSR code
sees the EOPNOTSUPP, does not consider it an fatal error, and return 0
to user space.

If userspace does see it, maybe we should make it clearer it is not an
actually error. 

"Cannot offload more than two ports, using software bridging"

so something similar.

   Andrew