netdev - Re: [PATCH v5 net-next 2/7] net: ethtool: attach an XArray of custom RSS contexts to a netdevice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 18 Jun 2024 16:49:39 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: <edward.cree@....com>
Cc: <linux-net-drivers@....com>, <davem@...emloft.com>,
 <edumazet@...gle.com>, <pabeni@...hat.com>, Edward Cree
 <ecree.xilinx@...il.com>, <netdev@...r.kernel.org>,
 <habetsm.xilinx@...il.com>, <sudheer.mogilappagari@...el.com>,
 <jdamato@...tly.com>, <mw@...ihalf.com>, <linux@...linux.org.uk>,
 <sgoutham@...vell.com>, <gakula@...vell.com>, <sbhatta@...vell.com>,
 <hkelam@...vell.com>, <saeedm@...dia.com>, <leon@...nel.org>,
 <jacob.e.keller@...el.com>, <andrew@...n.ch>, <ahmed.zaki@...el.com>
Subject: Re: [PATCH v5 net-next 2/7] net: ethtool: attach an XArray of
 custom RSS contexts to a netdevice

On Tue, 18 Jun 2024 23:44:22 +0100 edward.cree@....com wrote:
> +		xa_erase(&dev->ethtool->rss_ctx, context);
> +		if (dev->ethtool_ops->cap_rss_ctx_supported)
> +			dev->ethtool_ops->set_rxfh(dev, &rxfh, NULL);
> +		else /* can't happen */
> +			pr_warn_once("No callback to remove RSS context from %s\n",
> +				     netdev_name(dev));

nit: I'd be tempted to call dev->ethtool_ops->set_rxfh()
     unconditionally. Is there a legit scenario where context 
     may exist but there's no set_rxfh callback?

If you prefer to keep the check - netdev_warn_once() ?