netdev - Re: [PATCH 2/2] dt-bindings: net: Convert fsl-fman to yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fc8a117d-9723-44fe-afa3-f1a5af37a1a6@kernel.org>
Date: Tue, 18 Jun 2024 08:18:41 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Frank Li <Frank.li@....com>
Cc: Yangbo Lu <yangbo.lu@....com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Richard Cochran <richardcochran@...il.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Madalin Bucur <madalin.bucur@....com>, Sean Anderson
 <sean.anderson@...o.com>, netdev@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, imx@...ts.linux.dev
Subject: Re: [PATCH 2/2] dt-bindings: net: Convert fsl-fman to yaml

On 17/06/2024 20:19, Frank Li wrote:
>>> +  reg:
>>> +    maxItems: 1
>>> +
>>> +  ranges: true
>>
>> That's odd. Why do you need ranges without children?
> 
> It think it is legacy method in driver.
> 
> 	muram_node = of_find_matching_node(fm_node, fman_muram_match);                              
>         if (!muram_node) {                                                                          
>                 err = -EINVAL;                                                                      
>                 dev_err(&of_dev->dev, "%s: could not find MURAM node\n",                            
>                         __func__);                                                                  
>                 goto fman_free;                                                                     
>         }                                                                                           
>                                                                                                     
>         err = of_address_to_resource(muram_node, 0,                                                 
>                                      &fman->dts_params.muram_res);                                  
>         if (err) {                                                                                  
>                 of_node_put(muram_node);                                                            
>                 dev_err(&of_dev->dev, "%s: of_address_to_resource() = %d\n",                        
>                         __func__, err);                                                             
>                 goto fman_free;                                                                     
>         }  

And how is this related to ranges?

>>

Best regards,
Krzysztof