netdev - Re: [PATCH net-next] net: sun3lance: Remove redundant assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 17 Jun 2024 18:00:06 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Kamal Heib <kheib@...hat.com>
Cc: netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>, Paolo
 Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next] net: sun3lance: Remove redundant assignment

On Fri, 14 Jun 2024 10:52:31 -0400 Kamal Heib wrote:
> There is no point in initializing an ndo to NULL, therefore the
> assignment is redundant and can be removed.
> 
> Signed-off-by: Kamal Heib <kheib@...hat.com>
> ---
>  drivers/net/ethernet/amd/sun3lance.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/amd/sun3lance.c b/drivers/net/ethernet/amd/sun3lance.c
> index 246f34c43765..fe12051d8471 100644
> --- a/drivers/net/ethernet/amd/sun3lance.c
> +++ b/drivers/net/ethernet/amd/sun3lance.c
> @@ -296,7 +296,6 @@ static const struct net_device_ops lance_netdev_ops = {
>  	.ndo_stop		= lance_close,
>  	.ndo_start_xmit		= lance_start_xmit,
>  	.ndo_set_rx_mode	= set_multicast_list,
> -	.ndo_set_mac_address	= NULL,
>  	.ndo_validate_addr	= eth_validate_addr,
>  };
>  

We seem to have a lot of these:

$ git grep -E '^[[:space:]]\.[a-z_]*[[:space:]]*= NULL,' -- drivers/net/
| wc -l
287

and we try to discourage folks from sending cleanup patches to
very old device drivers. So, unfortunately, I'd prefer to leave 
this code as is.