netdev - Re: [PATCH net-next v2 1/2] net: dsa: mt7530: factor out bridge join/leave logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2ea4d24a-c345-463a-8160-2675b8339d79@universe-factory.net>
Date: Tue, 18 Jun 2024 08:22:19 +0200
From: Matthias Schiffer <mschiffer@...verse-factory.net>
To: Arınç ÜNAL <arinc.unal@...nc9.com>,
 Daniel Golle <daniel@...rotopia.org>, DENG Qingfang <dqfext@...il.com>,
 Sean Wang <sean.wang@...iatek.com>
Cc: Andrew Lunn <andrew@...n.ch>, Florian Fainelli <f.fainelli@...il.com>,
 Vladimir Oltean <olteanv@...il.com>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Matthias Brugger <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH net-next v2 1/2] net: dsa: mt7530: factor out bridge
 join/leave logic

On 18/06/2024 06:48, Arınç ÜNAL wrote:
> On 17/06/2024 21.30, Matthias Schiffer wrote:
>> As preparation for implementing bridge port isolation, move the logic to
>> add and remove bits in the port matrix into a new helper
>> mt7530_update_port_member(), which is called from
>> mt7530_port_bridge_join() and mt7530_port_bridge_leave().
>>
>> No functional change intended.
>>
>> Signed-off-by: Matthias Schiffer <mschiffer@...verse-factory.net>
> 
> I see that my review of the previous version of this patch was completely
> ignored. Why?
> 
> Arınç

Ugh, I somehow overlooked the review mail for this patch. Sorry about that, 
will address your comments in v3.

Matthias

Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (841 bytes)