netdev - RE: [PATCH net] selftests: openvswitch: Use bash as interpreter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6084a57c191543568e6ec1828ec0efe4@AcuMS.aculab.com>
Date: Wed, 19 Jun 2024 09:21:35 +0000
From: David Laight <David.Laight@...LAB.COM>
To: 'Simon Horman' <horms@...nel.org>, Przemek Kitszel
	<przemyslaw.kitszel@...el.com>
CC: Aaron Conole <aconole@...hat.com>, Adrian Moreno <amorenoz@...hat.com>,
	Pravin B Shelar <pshelar@....org>, Shuah Khan <shuah@...nel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, "dev@...nvswitch.org"
	<dev@...nvswitch.org>, "linux-kselftest@...r.kernel.org"
	<linux-kselftest@...r.kernel.org>, "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, "Paolo
 Abeni" <pabeni@...hat.com>
Subject: RE: [PATCH net] selftests: openvswitch: Use bash as interpreter

From: Simon Horman
> Sent: 17 June 2024 11:34
...
> > sidenote: I like very much the idea to use the least powerful tool, like
> > sh vs bash, awk vs gawk, but it breaks when we forget what is outside of
> > the scope of the former/standard.
> > Perhaps for shell, we could convert all the selftests at once?
> 
> Thanks,
> 
> Now that you mention it, I have the same feelings.
> 
> Do we ever expect to use the minimal tools, when other
> parts of the test suite depend on the enhanced ones?

Certainly trying to avoid bash-isms seems like a good idea.
Especially in scripts where it isn't really that hard.
OTOH avoiding posix features (so the script will run on a traditional SYSV /bin/sh)
is probably excessive.

I'd use "${foo%"${foo#?}"}" to get the first character without bash-isms.
But, IIRC, one version of ash/dash made a 'pig's breakfast' of the nested
pattern match.
(Most syntax highlighters don't get the quoting right either...)

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)