netdev - RE: [EXTERNAL] Re: [net PATCH] octeontx2-pf: Fix linking objects into multiple modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 19 Jun 2024 12:08:59 +0000
From: Geethasowjanya Akula <gakula@...vell.com>
To: Simon Horman <horms@...nel.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "davem@...emloft.net"
	<davem@...emloft.net>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        Sunil Kovvuri Goutham
	<sgoutham@...vell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@...vell.com>,
        Hariprasad Kelam <hkelam@...vell.com>
Subject: RE: [EXTERNAL] Re: [net PATCH] octeontx2-pf: Fix linking objects into
 multiple modules



From: Simon Horman <horms@...nel.org> 
Sent: Wednesday, June 19, 2024 4:35 PM
To: Geethasowjanya Akula <gakula@...vell.com>
Cc: netdev@...r.kernel.org; linux-kernel@...r.kernel.org; kuba@...nel.org; davem@...emloft.net; pabeni@...hat.com; edumazet@...gle.com; Sunil Kovvuri Goutham <sgoutham@...vell.com>; Subbaraya Sundeep Bhatta <sbhatta@...vell.com>; Hariprasad Kelam <hkelam@...vell.com>
Subject: [EXTERNAL] Re: [net PATCH] octeontx2-pf: Fix linking objects into multiple modules

>> This patch fixes the below build warning messages that are
>> caused due to linking same files to multiple modules by
>> exporting the required symbols.
>> 
>> "scripts/Makefile.build:244: drivers/net/ethernet/marvell/octeontx2/nic/Makefile:
>> otx2_devlink.o is added to multiple modules: rvu_nicpf rvu_nicvf
>> 
>> scripts/Makefile.build:244: drivers/net/ethernet/marvell/octeontx2/nic/Makefile:
>> otx2_dcbnl.o is added to multiple modules: rvu_nicpf rvu_nicvf"
>> 
>> Fixes: 8e67558177f8 ("octeontx2-pf: PFC config support with DCBx").
>> Signed-off-by: Geetha sowjanya <mailto:gakula@...vell.com>

>Thanks Geetha,

>I checked and it does not seem to be possible to compile
>rvu_nicvf as a built-in and rvu_nicpf as a module,
>which was my only concern about this.
Yes, it can be ignored as VF can not be enabled without PF driver loaded.

>Reviewed-by: Simon Horman <mailto:horms@...nel.org>