netdev - Re: [PATCH v2] net: missing check virtio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240618174500.49a3045b@kernel.org>
Date: Tue, 18 Jun 2024 17:45:00 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Denis Arefev <arefev@...mel.ru>
Cc: jiri@...nulli.us, edumazet@...gle.com, eperezma@...hat.com,
 jasowang@...hat.com, linux-kernel@...r.kernel.org,
 lvc-project@...uxtesting.org, mst@...hat.com, netdev@...r.kernel.org,
 virtualization@...ts.linux.dev, xuanzhuo@...ux.alibaba.com
Subject: Re: [PATCH v2] net: missing check virtio

On Fri, 14 Jun 2024 13:18:26 +0300 Denis Arefev wrote:
> Yeah, I was thinking of adding Fixes: 
> 
> But this code is new, it complements what is done.
> 1. check (!(ret && (hdr->gso_size > needed) &&
>                ((remainder > needed) || (remainder == 0)))) 
>  complements comit 0f6925b3e8da0
> 
> 2. The setting of the SKBFL_SHARED_FRAG flag can be associated with this comit cef401de7be8c.
> In the skb_checksum_help function, a check for skb_has_shared_frag has been added.
> If the flag is not set, the skb buffer will remain non-linear, which is not good. 

The Fixes tag indicates how far back the bug would trigger.