netdev - Re: [PATCH v5 net-next 4/7] net: ethtool: let the core choose RSS context IDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 19 Jun 2024 13:08:15 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: <edward.cree@....com>
Cc: <linux-net-drivers@....com>, <davem@...emloft.com>,
 <edumazet@...gle.com>, <pabeni@...hat.com>, Edward Cree
 <ecree.xilinx@...il.com>, <netdev@...r.kernel.org>,
 <habetsm.xilinx@...il.com>, <sudheer.mogilappagari@...el.com>,
 <jdamato@...tly.com>, <mw@...ihalf.com>, <linux@...linux.org.uk>,
 <sgoutham@...vell.com>, <gakula@...vell.com>, <sbhatta@...vell.com>,
 <hkelam@...vell.com>, <saeedm@...dia.com>, <leon@...nel.org>,
 <jacob.e.keller@...el.com>, <andrew@...n.ch>, <ahmed.zaki@...el.com>
Subject: Re: [PATCH v5 net-next 4/7] net: ethtool: let the core choose RSS
 context IDs

On Wed, 19 Jun 2024 10:24:35 -0700 Jakub Kicinski wrote:
> On Tue, 18 Jun 2024 23:44:24 +0100 edward.cree@....com wrote:
> > + * @create_rxfh_context: Create a new RSS context with the specified RX flow
> > + *	hash indirection table, hash key, and hash function.
> > + *	Parameters which are set to %NULL or zero will be populated to
> > + *	appropriate defaults by the driver.  
> 
> The defaults will most likely "inherit" whatever is set in context 0.
> So the driver _may_ init the values according to its preferences
> but they will not be used by the core (specifically not reported to
> user space via ethtool netlink)
> 
> Does that match your thinking?

I was thinking about the key, hfunc and xfrm. Indirection table
needs to get reported.