netdev - Re: [PATCH v0] net: dsa: mv88e6xxx: Add FID map cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a79192718fad9e85bf336c7a6c8864c523456033.camel@alliedtelesis.co.nz>
Date: Wed, 19 Jun 2024 23:17:26 +0000
From: Aryan Srivastava <Aryan.Srivastava@...iedtelesis.co.nz>
To: "andrew@...n.ch" <andrew@...n.ch>
CC: "olteanv@...il.com" <olteanv@...il.com>, "davem@...emloft.net"
	<davem@...emloft.net>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "kuba@...nel.org" <kuba@...nel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "f.fainelli@...il.com" <f.fainelli@...il.com>,
	"pabeni@...hat.com" <pabeni@...hat.com>
Subject: Re: [PATCH v0] net: dsa: mv88e6xxx: Add FID map cache

Hi Andrew,
On Mon, 2024-06-10 at 14:23 +0200, Andrew Lunn wrote:
> On Mon, Jun 10, 2024 at 05:07:23PM +1200, Aryan Srivastava wrote:
> > Add a cached FID bitmap. This mitigates the need to
> > walk all VTU entries to find the next free FID.
> > 
> > Walk VTU once, then store read FID map into bitmap. Use
> > and manipulate this bitmap from now on, instead of re-reading
> > HW for the FID map.
> > 
> > The repeatedly VTU walks are costly can result in taking ~40 mins
> > if ~4000 vlans are added. Caching the FID map reduces this time
> > to <2 mins.
> 
> How long does the first walk take? Rather than having fid_populated,
> i
> wounder if the walk should just be done in mv88e6xxx_vtu_setup() or
> mv88e6xxx_atu_setup().
> 
>         Andrew
I agree, will implement this. The first walk does not take long, but
would be better served in the setup.

Thanks,
Aryan.