netdev - Re: [PATCH net-next v11 4/7] net: tn40xx: add basic Tx handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 20 Jun 2024 08:49:34 +0900 (JST)
From: FUJITA Tomonori <fujita.tomonori@...il.com>
To: kuba@...nel.org
Cc: fujita.tomonori@...il.com, netdev@...r.kernel.org, andrew@...n.ch,
 horms@...nel.org, jiri@...nulli.us, pabeni@...hat.com,
 linux@...linux.org.uk, hfdevel@....net, naveenm@...vell.com,
 jdamato@...tly.com
Subject: Re: [PATCH net-next v11 4/7] net: tn40xx: add basic Tx handling

On Wed, 19 Jun 2024 07:55:07 -0700
Jakub Kicinski <kuba@...nel.org> wrote:

> On Wed, 19 Jun 2024 12:44:22 +0900 (JST) FUJITA Tomonori wrote:
>> >> +static void tn40_link_changed(struct tn40_priv *priv)
>> >> +{
>> >> +	u32 link = tn40_read_reg(priv,
>> >> +				 TN40_REG_MAC_LNK_STAT) & TN40_MAC_LINK_STAT;
>> >> +
>> >> +	netdev_dbg(priv->ndev, "link changed %u\n", link);  
>> > 
>> > shouldn't this call netif_carrier_on / off?  
>> 
>> According to phylink doc, a driver shouldn't call them?
> 
> My bad, forgot you're using phylink!
> Purely out of my own curiosity - do you know what this link change
> detects, then? In my mental model PHY detects the link, sends some 
> form of a notification, then MAC gets configured.

It seems that this link change detects what the PHY detects. The
original driver doesn't use PHY registers for that purpose.