[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <187e4082-c297-472d-9185-58f08572d68c@davidwei.uk>
Date: Tue, 18 Jun 2024 22:40:04 -0700
From: David Wei <dw@...idwei.uk>
To: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>, saeedm@...dia.com
Cc: leon@...nel.org, tariqt@...dia.com, davem@...emloft.net,
edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] net/mlx5: Lag, Remove NULL check before dev_{put, hold}
On 2024-06-18 20:53, Jiapeng Chong wrote:
> The call netdev_{put, hold} of dev_{put, hold} will check NULL, so there
> is no need to check before using dev_{put, hold}, remove it to silence
> the warning:
>
> ./drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c:1518:2-10: WARNING: NULL check before dev_{put, hold} functions is not needed.
>
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9361
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c b/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c
> index d0871c46b8c5..a2fd9a84f877 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c
> @@ -1514,8 +1514,7 @@ struct net_device *mlx5_lag_get_roce_netdev(struct mlx5_core_dev *dev)
> } else {
> ndev = ldev->pf[MLX5_LAG_P1].netdev;
> }
> - if (ndev)
> - dev_hold(ndev);
> + dev_hold(ndev);
Looks safe, dev_hold() -> netdev_hold() which checks for ndev.
Reviewed-by: David Wei <dw@...idwei.uk>
>
> unlock:
> spin_unlock_irqrestore(&lag_lock, flags);
Powered by blists - more mailing lists