netdev - Re: [PATCH v2 net-next 2/2] net: airoha: Introduce ethernet support for EN7581 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZnKGmhVOPV-W2LWA@lore-desk>
Date: Wed, 19 Jun 2024 09:19:54 +0200
From: Lorenzo Bianconi <lorenzo@...nel.org>
To: Andrew Lunn <andrew@...n.ch>
Cc: netdev@...r.kernel.org, nbd@....name, lorenzo.bianconi83@...il.com,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, conor@...nel.org,
	linux-arm-kernel@...ts.infradead.org, robh+dt@...nel.org,
	krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
	devicetree@...r.kernel.org, catalin.marinas@....com,
	will@...nel.org, upstream@...oha.com,
	angelogioacchino.delregno@...labora.com,
	benjamin.larsson@...exis.eu, linux-clk@...r.kernel.org,
	rkannoth@...vell.com, sgoutham@...vell.com
Subject: Re: [PATCH v2 net-next 2/2] net: airoha: Introduce ethernet support
 for EN7581 SoC

> > +static void airoha_fe_maccr_init(struct airoha_eth *eth)
> > +{
> 
> ...
> 
> > +	airoha_fe_wr(eth, REG_FE_VIP_PATN(11), 0xc057); /* PPP->IPv6CP (0xc057) */
> 
> include/uapi/linux/ppp_defs.h
> #define PPP_IPV6CP      0x8057  /* IPv6 Control Protocol */
> 
> Are these the same thing? Why is there one bit difference?

ack, I guess there is a typo here.

> 
> 
> > +	airoha_fe_wr(eth, REG_FE_VIP_PATN(17), 0x1ae0);
> > +	airoha_fe_wr(eth, REG_FE_VIP_EN(17),
> > +		     PATN_FCPU_EN_MASK | PATN_SP_EN_MASK |
> > +		     FIELD_PREP(PATN_TYPE_MASK, 3) | PATN_EN_MASK);
> > +
> > +	airoha_fe_wr(eth, REG_FE_VIP_PATN(18), 0x1ae00000);
> > +	airoha_fe_wr(eth, REG_FE_VIP_EN(18),
> > +		     PATN_FCPU_EN_MASK | PATN_DP_EN_MASK |
> > +		     FIELD_PREP(PATN_TYPE_MASK, 3) | PATN_EN_MASK);
> 
> > +	airoha_fe_wr(eth, REG_FE_VIP_PATN(22), 0xaaaa);
> 
> Please add a comment what these match.

ack, I will look into them.

> 
> > +static int airoha_dev_change_mtu(struct net_device *dev, int new_mtu)
> > +{
> > +	dev->mtu = new_mtu;
> > +
> > +	return 0;
> > +}
> > +
> 
> I don't think this is needed. Look at __dev_set_mtu().

ack, I will get rid of it in v3.

Regards,
Lorenzo

> 
>     Andrew
> 
> ---
> pw-bot: cr

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)