netdev - Re: [PATCH net-next v7 2/5] net: phy: mediatek: Move LED and read/write page helper functions into mtk phy lib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5d5d5044093d9b6fd9bffdb01a0afe59259c54bb.camel@mediatek.com>
Date: Wed, 19 Jun 2024 08:13:23 +0000
From: SkyLake Huang (黃啟澤)
	<SkyLake.Huang@...iatek.com>
To: "horms@...nel.org" <horms@...nel.org>
CC: "andrew@...n.ch" <andrew@...n.ch>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-mediatek@...ts.infradead.org"
	<linux-mediatek@...ts.infradead.org>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux@...linux.org.uk"
	<linux@...linux.org.uk>, "kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"dqfext@...il.com" <dqfext@...il.com>,
	Steven Liu (劉人豪) <steven.liu@...iatek.com>,
	"matthias.bgg@...il.com" <matthias.bgg@...il.com>, "davem@...emloft.net"
	<davem@...emloft.net>, "hkallweit1@...il.com" <hkallweit1@...il.com>,
	"daniel@...rotopia.org" <daniel@...rotopia.org>,
	"angelogioacchino.delregno@...labora.com"
	<angelogioacchino.delregno@...labora.com>
Subject: Re: [PATCH net-next v7 2/5] net: phy: mediatek: Move LED and
 read/write page helper functions into mtk phy lib

On Mon, 2024-06-17 at 12:51 +0100, Simon Horman wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  On Thu, Jun 13, 2024 at 06:40:20PM +0800, Sky Huang wrote:
> > From: "SkyLake.Huang" <skylake.huang@...iatek.com>
> > 
> > This patch moves mtk-ge-soc.c's LED code into mtk phy lib. We
> > can use those helper functions in mtk-ge.c as well. That is to
> > say, we have almost the same HW LED controller design in
> > mt7530/mt7531/mt7981/mt7988's Giga ethernet phy.
> > 
> > Also integrate read/write pages into one helper function. They
> > are basically the same.
> > 
> > Signed-off-by: SkyLake.Huang <skylake.huang@...iatek.com>
> 
> ...
> 
> >  static int mt798x_phy_led_blink_set(struct phy_device *phydev, u8
> index,
> >      unsigned long *delay_on,
> >      unsigned long *delay_off)
> >  {
> >  bool blinking = false;
> >  int err = 0;
> > +struct mtk_socphy_priv *priv = phydev->priv;
> 
> Hi Sky,
> 
> A minor nit from my side.
> 
> If you need to respin this patchset for some other reason, please
> consider
> preserving reverse xmas tree order - longest line to shortest - in
> this
> function.
> 
> Likewise there are a few other changes in this patch which look like
> they
> could be trivially updated to preserve or adopt reverse xmas tree
> order.
> 
> Edward Cree's tool can be of assistance here:
> https://github.com/ecree-solarflare/xmastree
> 
> >  
> >  if (index > 1)
> >  return -EINVAL;
Hi Simon,
  Thanks for reminding. There are some left-overs in mediatek-ge-soc.c
of current version on reverse Xmas tree order. I missed that. I'll
clean this up if we need to respin mtk-ge-soc.c again.

BRs,
Sky