netdev - Re: [PATCH net-next v6 9/9] ethtool: Add ability to flash transceiver modules' firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240619183500.5635a7a1@kernel.org>
Date: Wed, 19 Jun 2024 18:35:00 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Danielle Ratson <danieller@...dia.com>
Cc: <netdev@...r.kernel.org>, <davem@...emloft.net>, <edumazet@...gle.com>,
 <pabeni@...hat.com>, <corbet@....net>, <linux@...linux.org.uk>,
 <sdf@...gle.com>, <kory.maincent@...tlin.com>,
 <maxime.chevallier@...tlin.com>, <vladimir.oltean@....com>,
 <przemyslaw.kitszel@...el.com>, <ahmed.zaki@...el.com>,
 <richardcochran@...il.com>, <shayagr@...zon.com>,
 <paul.greenwalt@...el.com>, <jiri@...nulli.us>,
 <linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <mlxsw@...dia.com>, <idosch@...dia.com>, <petrm@...dia.com>
Subject: Re: [PATCH net-next v6 9/9] ethtool: Add ability to flash
 transceiver modules' firmware

On Wed, 19 Jun 2024 15:17:27 +0300 Danielle Ratson wrote:
> +	switch (sk_priv->type) {
> +	case ETHTOOL_SOCK_TYPE_MODULE_FW_FLASH:
> +		ethnl_module_fw_flash_sock_destroy(sk_priv);
> +	default:
> +		break;

The compilers are nit picking on this:

net/ethtool/netlink.c:57:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
   57 |         default:
      |         ^
net/ethtool/netlink.c:57:2: note: insert 'break;' to avoid fall-through
   57 |         default:
      |         ^
-- 
pw-bot: cr