netdev - Re: [PATCH net-next v7 5/5] net: phy: add driver for built-in 2.5G ethernet PHY on MT7988

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 20 Jun 2024 04:32:25 +0000
From: SkyLake Huang (黃啟澤)
	<SkyLake.Huang@...iatek.com>
To: "linux@...linux.org.uk" <linux@...linux.org.uk>
CC: "andrew@...n.ch" <andrew@...n.ch>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-mediatek@...ts.infradead.org"
	<linux-mediatek@...ts.infradead.org>, "kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "dqfext@...il.com" <dqfext@...il.com>,
	"matthias.bgg@...il.com" <matthias.bgg@...il.com>,
	Steven Liu (劉人豪) <steven.liu@...iatek.com>,
	"davem@...emloft.net" <davem@...emloft.net>, "hkallweit1@...il.com"
	<hkallweit1@...il.com>, "angelogioacchino.delregno@...labora.com"
	<angelogioacchino.delregno@...labora.com>, "daniel@...rotopia.org"
	<daniel@...rotopia.org>
Subject: Re: [PATCH net-next v7 5/5] net: phy: add driver for built-in 2.5G
 ethernet PHY on MT7988

On Wed, 2024-06-19 at 21:09 +0100, Russell King (Oracle) wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  On Wed, Jun 19, 2024 at 11:44:32AM +0000, SkyLake Huang (黃啟澤) wrote:
> > On Wed, 2024-06-19 at 10:09 +0100, Russell King (Oracle) wrote:
> > >   
> > > External email : Please do not click links or open attachments
> until
> > > you have verified the sender or the content.
> > >  On Thu, Jun 13, 2024 at 06:40:23PM +0800, Sky Huang wrote:
> > > > +static struct phy_driver mtk_gephy_driver[] = {
> > > > +{
> > > > +PHY_ID_MATCH_MODEL(MTK_2P5GPHY_ID_MT7988),
> > > > +.name= "MediaTek MT7988 2.5GbE PHY",
> > > > +.probe= mt798x_2p5ge_phy_probe,
> > > > +.config_init= mt798x_2p5ge_phy_config_init,
> > > > +.config_aneg    = mt798x_2p5ge_phy_config_aneg,
> > > > +.get_features= mt798x_2p5ge_phy_get_features,
> > > > +.read_status= mt798x_2p5ge_phy_read_status,
> > > > +.get_rate_matching= mt798x_2p5ge_phy_get_rate_matching,
> > > > +.suspend= genphy_suspend,
> > > > +.resume= genphy_resume,
> > > > +.read_page= mtk_phy_read_page,
> > > > +.write_page= mtk_phy_write_page,
> > > > +.led_blink_set= mt798x_2p5ge_phy_led_blink_set,
> > > > +.led_brightness_set = mt798x_2p5ge_phy_led_brightness_set,
> > > > +.led_hw_is_supported = mt798x_2p5ge_phy_led_hw_is_supported,
> > > > +.led_hw_control_get = mt798x_2p5ge_phy_led_hw_control_get,
> > > > +.led_hw_control_set = mt798x_2p5ge_phy_led_hw_control_set,
> > > 
> > > I don't see the point of trying to align some of these method
> > > declarators but not others. Consistency is important.
> > > 
> > Sorry I don't get your point on this. What do you mean by "trying
> to
> > align some of these method declarators but not others"? Do you mean
> > "mt798x_2p5ge_phy" prefix?
> 
> Some of the method initialisers are:
> 
> .foo<tab>= method_foo,
> .bar<tab>= method_bar,
> ...
> 
> while other are:
> 
> .longlongname<space>= methodlonglongname,
> 
> So what this causes is:
> 
> .foo= method_foo,
> .bar= method_bar,
> .longlongbaz = methodlonglongbaz,
> 
> which looks messy - why use tabs for the short ones and a space for
> the others. Why not be consistent, e.g.:
> 
> .foo = method_foo,
> .bar = method_bar,
> .longlongbaz = methodlonglongbaz,
> 
> ?
> 
> -- 
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

Got it. I'll fix this driver with "foo<space>= method_foo," and add
another patch to fix mtk-ge.c & mtk-ge-soc.c in next version.

BRs,
Sky