netdev - Re: [PATCH 3/3] dt-bindings: net: qcom: ethernet: Add interconnect properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <505739da-6724-4928-bea8-f03d673544bc@kernel.org>
Date: Thu, 20 Jun 2024 09:12:02 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Sagar Cheluvegowda <quic_scheluve@...cinc.com>,
 Vinod Koul <vkoul@...nel.org>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>,
 Jose Abreu <joabreu@...opsys.com>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Maxime Coquelin
 <mcoquelin.stm32@...il.com>, Russell King <linux@...linux.org.uk>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Bhupesh Sharma <bhupesh.sharma@...aro.org>
Cc: kernel@...cinc.com, Andrew Halaney <ahalaney@...hat.com>,
 linux-arm-msm@...r.kernel.org, netdev@...r.kernel.org,
 linux-stm32@...md-mailman.stormreply.com,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org
Subject: Re: [PATCH 3/3] dt-bindings: net: qcom: ethernet: Add interconnect
 properties

On 20/06/2024 00:41, Sagar Cheluvegowda wrote:
> Add documentation for the interconnect and interconnect-names
> properties required when voting for AHB and AXI buses.
> 
> Signed-off-by: Sagar Cheluvegowda <quic_scheluve@...cinc.com>
> ---
>  Documentation/devicetree/bindings/net/qcom,ethqos.yaml | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
> index 6672327358bc..bf2a197342a5 100644
> --- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
> +++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
> @@ -63,6 +63,14 @@ properties:
>  
>    dma-coherent: true
>  
> +  interconnects:
> +    maxItems: 2
> +
> +  interconnect-names:
> +    items:
> +      - const: axi_icc_path
> +      - const: ahb_icc_path

Drop "_icc_path", redundant and instead describe it like other bindings.
Also, names use hyphens. Just open any Qualcomm DTS.

Best regards,
Krzysztof