netdev - Re: [PATCH net-next v3 05/10] net: openvswitch: add emit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAG=2xmO5jY7Rj=O+ZToRn=aSLXSPc4anzXfZM+_-PxMvqacWhg@mail.gmail.com>
Date: Thu, 20 Jun 2024 02:29:43 -0500
From: Adrián Moreno <amorenoz@...hat.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, aconole@...hat.com, echaudro@...hat.com, 
	horms@...nel.org, i.maximets@....org, dev@...nvswitch.org, 
	Donald Hunter <donald.hunter@...il.com>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, 
	Pravin B Shelar <pshelar@....org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v3 05/10] net: openvswitch: add emit_sample action

On Wed, Jun 19, 2024 at 06:39:43PM GMT, Jakub Kicinski wrote:
> On Wed, 19 Jun 2024 23:00:06 +0200 Adrian Moreno wrote:
> > +	OVS_EMIT_SAMPLE_ATTR_UNPSEC,
>
> Are you using this one? Looking closely I presume not, since it's
> misspelled ;) You can assign = 1 to GROUP, no need to name the value
> for 0.

Good point, thanks.
The openvswitch header seems full of unused names for value 0.
I guess it's OK to break the local "style" if we're improving it?
Or is it better to get rid of all of them in a single cleaning patch?

>
> > +	OVS_EMIT_SAMPLE_ATTR_GROUP,	/* u32 number. */
> > +	OVS_EMIT_SAMPLE_ATTR_COOKIE,	/* Optional, user specified cookie. */
> > +	__OVS_EMIT_SAMPLE_ATTR_MAX
>
> kdoc is complaining that __OVS_EMIT_SAMPLE_ATTR_MAX is not documented.
> You can add:
>
> 	/* private: */
>
> before, take a look at include/uapi/linux/netdev.h for example.

Thanks. Will do.
--
Adrián