netdev - Re: [PATCH net] bonding: fix incorrect software timestamping report

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 20 Jun 2024 11:13:01 +0200
From: Kory Maincent <kory.maincent@...tlin.com>
To: Hangbin Liu <liuhangbin@...il.com>
Cc: netdev@...r.kernel.org, Jay Vosburgh <j.vosburgh@...il.com>, Andy
 Gospodarek <andy@...yhouse.net>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo
 Abeni <pabeni@...hat.com>, Richard Cochran <richardcochran@...il.com>,
 Florian Fainelli <florian.fainelli@...adcom.com>, Liang Li
 <liali@...hat.com>
Subject: Re: [PATCH net] bonding: fix incorrect software timestamping report

On Thu, 20 Jun 2024 16:56:26 +0800
Hangbin Liu <liuhangbin@...il.com> wrote:

> The __ethtool_get_ts_info function returns directly if the device has a
> get_ts_info() method. For bonding with an active slave, this works correctly
> as we simply return the real device's timestamping information. However,
> when there is no active slave, we only check the slave's TX software
> timestamp information. We still need to set the phc index and RX timestamp
> information manually. Otherwise, the result will be look like:
> 
>   Time stamping parameters for bond0:
>   Capabilities:
>           software-transmit
>   PTP Hardware Clock: 0
>   Hardware Transmit Timestamp Modes: none
>   Hardware Receive Filter Modes: none
> 
> This issue does not affect VLAN or MACVLAN devices, as they only have one
> downlink and can directly use the downlink's timestamping information.

Acked-by: Kory Maincent <kory.maincent@...tlin.com>

--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com