netdev - Re: [PATCH 14/15] net: marvell: Convert tasklet API to new bottom half workqueue mechanism

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 21 Jun 2024 22:19:57 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Allen Pais <allen.lkml@...il.com>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH 14/15] net: marvell: Convert tasklet API to new bottom
 half workqueue mechanism

On Fri, Jun 21, 2024 at 11:39:46AM -0700, Allen Pais wrote:
> Migrate tasklet APIs to the new bottom half workqueue mechanism. It
> replaces all occurrences of tasklet usage with the appropriate workqueue
> APIs throughout the marvell driver.

drivers. You are modifying two here.

> diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> index 671368d2c77e..47fe71a8f57e 100644
> --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> @@ -2628,9 +2628,7 @@ static u32 mvpp2_txq_desc_csum(int l3_offs, __be16 l3_proto,
>   * The number of sent descriptors is returned.
>   * Per-thread access
>   *
> - * Called only from mvpp2_txq_done(), called from mvpp2_tx()
> - * (migration disabled) and from the TX completion tasklet (migration
> - * disabled) so using smp_processor_id() is OK.
> + * Called only from mvpp2_txq_done().

I've not followed the development of the bottom half workqueue
mechanism. I assume the documented assumption is still true? If so,
please could you reword it as appropriate, rather than delete it.

Thanks
	Andrew
	
    Andrew

---
pw-bot: cr