[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240620203918.407185c9@kernel.org>
Date: Thu, 20 Jun 2024 20:39:18 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Heng Qi <hengqi@...ux.alibaba.com>
Cc: netdev@...r.kernel.org, virtualization@...ts.linux.dev, "David S .
Miller" <davem@...emloft.net>, Paolo Abeni <pabeni@...hat.com>, Eric
Dumazet <edumazet@...gle.com>, Jason Wang <jasowang@...hat.com>, "Michael S
. Tsirkin" <mst@...hat.com>, Brett Creeley <bcreeley@....com>, Ratheesh
Kannoth <rkannoth@...vell.com>, Alexander Lobakin
<aleksander.lobakin@...el.com>, Xuan Zhuo <xuanzhuo@...ux.alibaba.com>, Tal
Gilboa <talgi@...dia.com>, Jonathan Corbet <corbet@....net>,
linux-doc@...r.kernel.org, Maxime Chevallier
<maxime.chevallier@...tlin.com>, Jiri Pirko <jiri@...nulli.us>, Paul
Greenwalt <paul.greenwalt@...el.com>, Ahmed Zaki <ahmed.zaki@...el.com>,
Vladimir Oltean <vladimir.oltean@....com>, Kory Maincent
<kory.maincent@...tlin.com>, Andrew Lunn <andrew@...n.ch>,
justinstitt@...gle.com, donald.hunter@...il.com, Eugenio PĂ©rez <eperezma@...hat.com>, Andrew Morton
<akpm@...ux-foundation.org>, Dragos Tatulea <dtatulea@...dia.com>, Rahul
Rameshbabu <rrameshbabu@...dia.com>, Heiner Kallweit
<hkallweit1@...il.com>, Przemek Kitszel <przemyslaw.kitszel@...el.com>,
awel Dembicki <paweldembicki@...il.com>
Subject: Re: [PATCH RESEND net-next v14 3/5] ethtool: provide customized dim
profile management
On Tue, 18 Jun 2024 10:56:42 +0800 Heng Qi wrote:
> + if (dev->irq_moder && dev->irq_moder->profile_flags & DIM_PROFILE_RX) {
> + ret = ethnl_update_profile(dev, &dev->irq_moder->rx_profile,
> + tb[ETHTOOL_A_COALESCE_RX_PROFILE],
> + info->extack);
> + if (ret < 0)
> + return ret;
> + }
> +
> + if (dev->irq_moder && dev->irq_moder->profile_flags & DIM_PROFILE_TX) {
> + ret = ethnl_update_profile(dev, &dev->irq_moder->tx_profile,
> + tb[ETHTOOL_A_COALESCE_TX_PROFILE],
> + info->extack);
> + if (ret < 0)
> + return ret;
> + }
One last thing - you're missing updating the &mod bit.
When any of the settings were change mod should be set
to true so that we send a notification to user space,
that the settings have been modified.
Powered by blists - more mailing lists