netdev - RE: [Intel-wired-lan] [PATCH iwl-next] ice: Distinguish driver reset and removal for AQ shutdown

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 21 Jun 2024 04:27:07 +0000
From: "Pucha, HimasekharX Reddy" <himasekharx.reddy.pucha@...el.com>
To: Marcin Szycik <marcin.szycik@...ux.intel.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "Gardocki, PiotrX" <piotrx.gardocki@...el.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "Zaki, Ahmed" <ahmed.zaki@...el.com>, "Kitszel,
 Przemyslaw" <przemyslaw.kitszel@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next] ice: Distinguish driver reset
 and removal for AQ shutdown

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Marcin Szycik
> Sent: Friday, June 14, 2024 4:08 PM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: Gardocki, PiotrX <piotrx.gardocki@...el.com>; netdev@...r.kernel.org; Marcin Szycik <marcin.szycik@...ux.intel.com>; Zaki, Ahmed <ahmed.zaki@...el.com>; Kitszel, Przemyslaw <przemyslaw.kitszel@...el.com>
> Subject: [Intel-wired-lan] [PATCH iwl-next] ice: Distinguish driver reset and removal for AQ shutdown
>
> From: Piotr Gardocki <piotrx.gardocki@...el.com>
>
> Admin queue command for shutdown AQ contains a flag to indicate driver unload. However, the flag is always set in the driver, even for resets. It can cause the firmware to consider driver as unloaded once the PF reset is triggered on all ports of device, which could lead to unexpected results.
>
> Add an additional function parameter to functions that shutdown AQ, indicating whether the driver is actually unloading.
>
> Reviewed-by: Ahmed Zaki <ahmed.zaki@...el.com>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> Signed-off-by: Piotr Gardocki <piotrx.gardocki@...el.com>
> Signed-off-by: Marcin Szycik <marcin.szycik@...ux.intel.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_common.h   |  2 +-
>  drivers/net/ethernet/intel/ice/ice_controlq.c | 19 +++++++++++--------
>  drivers/net/ethernet/intel/ice/ice_main.c     |  6 +++---
>  3 files changed, 15 insertions(+), 12 deletions(-)
>

Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@...el.com> (A Contingent worker at Intel)