netdev - Re: [PATCH v2 net] ionic: use dev_consume_skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240621182128.3a9481ce@kernel.org>
Date: Fri, 21 Jun 2024 18:21:28 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Shannon Nelson <shannon.nelson@....com>
Cc: <netdev@...r.kernel.org>, <davem@...emloft.net>, <edumazet@...gle.com>,
 <pabeni@...hat.com>, <brett.creeley@....com>, <drivers@...sando.io>
Subject: Re: [PATCH v2 net] ionic: use dev_consume_skb_any outside of napi

On Thu, 20 Jun 2024 12:25:19 -0700 Shannon Nelson wrote:
> -	work_done = ionic_tx_cq_service(cq, budget);
> +	work_done = ionic_tx_cq_service(cq, budget, true);

you gotta use budget. When budget is 0 you're in netpoll not in real
NAPI. So you can keep the bool but instead of unconditionally passing
true you gotta pass !!budget.
-- 
pw-bot: cr